[css-text] break-all opportunities to avoid breaking before first space #16843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 15, 2019
The 'white-space: break-spaces' feature, when used in combination with 'overfow-wrap: break-word' may allow breaking before the first space after a word. However, we should avoid it if there are previous opportunities, like white spaces. The 'word-break: break-all' feature allows breaking a word at any letter. Since the goal of this feature is produce the longest line as possible, these additional opportunities must be prioritized over any previous white space. Bug: 952254 Change-Id: I0b1c31219c0009c7050084dd552317342ec25b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613177 Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#660072}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1613177
branch
from
5b649d4
to
a5cd305
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'white-space: break-spaces' feature, when used in combination with
'overfow-wrap: break-word' may allow breaking before the first space
after a word.
However, we should avoid it if there are previous opportunities, like
white spaces.
The 'word-break: break-all' feature allows breaking a word at any
letter. Since the goal of this feature is produce the longest line as
possible, these additional opportunities must be prioritized over any
previous white space.
Bug: 952254
Change-Id: I0b1c31219c0009c7050084dd552317342ec25b8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613177
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#660072}