New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pypyPackages: enable sure (without checkPhase) #61541
Conversation
sure 1.4.6 added support for PyPy3, which the previous 1.2.x version didn't support, but this wasn't fixed in the update from 12d4cc1. However, just fixing this results in a test failure; it looks like it's a simple change in the internals of how PyPy throws some error messages, but is otherwise benign, but hasn't been caught upstream yet. ====================================================================== FAIL: test_old_api.test_that_contains_none that('foobar').contains(None) ---------------------------------------------------------------------- Traceback (most recent call last): File "/build/sure-1.4.11/sure/old.py", line 129, in raises self._src(*self._callable_args, **self._callable_kw) File "/build/sure-1.4.11/tests/test_old_api.py", line 548, in assertions assert that(b'foobar' if PY2 else 'foobar').contains(None) File "/build/sure-1.4.11/sure/old.py", line 437, in contains assert what in self._src, '%r should be in %r' % (what, self._src) TypeError: Can't convert 'NoneType' object to str implicitly During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/nix/store/rmz3gqbdhb32zpsbn183lmd4ysajv88m-pypy3.5-nose-1.3.7/site-packages/nose/case.py", line 197, in runTest self.test(*self.arg) File "/build/sure-1.4.11/tests/test_old_api.py", line 554, in test_that_contains_none error_msg File "/build/sure-1.4.11/sure/old.py", line 153, in raises msg, err)) AssertionError: <function test_that_contains_none.<locals>.assertions at 0x0000000001f09420> raised TypeError, but the exception message does not match. EXPECTED: 'NoneType' does not have the buffer interface GOT: Can't convert 'NoneType' object to str implicitly ---------------------------------------------------------------------- Signed-off-by: Austin Seipp <aseipp@pobox.com>
1a88229
to
3c2114f
Compare
please report the issue upstream |
ping @thoughtpolice |
Afraid I haven't had time to exactly write a good bug report for upstream as I've been busy for a few weeks (but I do still want this merged). Will try to get something reported soon. |
Thank you for your contributions.
|
I marked this as stale due to inactivity. → More info |
Reopen and rebase if you're still interested in this. |
sure 1.4.6 added support for pypy 3, which the previous 1.2.x version
didn't support, but this wasn't fixed in the update from
12d4cc1.
However, just fixing this results in a test failure; it looks like it's
a simple change in the internals of how PyPy throws some error messages,
but is otherwise benign, but hasn't been caught upstream yet.
Things done
sandbox
innix.conf
on non-NixOS)