Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypyPackages: enable sure (without checkPhase) #61541

Closed
wants to merge 1 commit into from

Conversation

thoughtpolice
Copy link
Member

@thoughtpolice thoughtpolice commented May 15, 2019

sure 1.4.6 added support for pypy 3, which the previous 1.2.x version
didn't support, but this wasn't fixed in the update from
12d4cc1.

However, just fixing this results in a test failure; it looks like it's
a simple change in the internals of how PyPy throws some error messages,
but is otherwise benign, but hasn't been caught upstream yet.

======================================================================
FAIL: test_old_api.test_that_contains_none
that('foobar').contains(None)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/build/sure-1.4.11/sure/old.py", line 129, in raises
    self._src(*self._callable_args, **self._callable_kw)
  File "/build/sure-1.4.11/tests/test_old_api.py", line 548, in
assertions
    assert that(b'foobar' if PY2 else 'foobar').contains(None)
  File "/build/sure-1.4.11/sure/old.py", line 437, in contains
    assert what in self._src, '%r should be in %r' % (what, self._src)
TypeError: Can't convert 'NoneType' object to str implicitly

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File
"/nix/store/rmz3gqbdhb32zpsbn183lmd4ysajv88m-pypy3.5-nose-1.3.7/site-packages/nose/case.py",
line 197, in runTest
    self.test(*self.arg)
  File "/build/sure-1.4.11/tests/test_old_api.py", line 554, in
test_that_contains_none
    error_msg
  File "/build/sure-1.4.11/sure/old.py", line 153, in raises
    msg, err))
AssertionError: <function test_that_contains_none.<locals>.assertions at
0x0000000001f09420> raised TypeError, but the exception message does not
                    match.

EXPECTED:
'NoneType' does not have the buffer interface

GOT:
Can't convert 'NoneType' object to str implicitly
----------------------------------------------------------------------
Things done

@thoughtpolice thoughtpolice requested a review from FRidh as a code owner May 15, 2019 12:09
@thoughtpolice thoughtpolice self-assigned this May 15, 2019
sure 1.4.6 added support for PyPy3, which the previous 1.2.x version
didn't support, but this wasn't fixed in the update from
12d4cc1.

However, just fixing this results in a test failure; it looks like it's
a simple change in the internals of how PyPy throws some error messages,
but is otherwise benign, but hasn't been caught upstream yet.

======================================================================
FAIL: test_old_api.test_that_contains_none
that('foobar').contains(None)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/build/sure-1.4.11/sure/old.py", line 129, in raises
    self._src(*self._callable_args, **self._callable_kw)
  File "/build/sure-1.4.11/tests/test_old_api.py", line 548, in
assertions
    assert that(b'foobar' if PY2 else 'foobar').contains(None)
  File "/build/sure-1.4.11/sure/old.py", line 437, in contains
    assert what in self._src, '%r should be in %r' % (what, self._src)
TypeError: Can't convert 'NoneType' object to str implicitly

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File
"/nix/store/rmz3gqbdhb32zpsbn183lmd4ysajv88m-pypy3.5-nose-1.3.7/site-packages/nose/case.py",
line 197, in runTest
    self.test(*self.arg)
  File "/build/sure-1.4.11/tests/test_old_api.py", line 554, in
test_that_contains_none
    error_msg
  File "/build/sure-1.4.11/sure/old.py", line 153, in raises
    msg, err))
AssertionError: <function test_that_contains_none.<locals>.assertions at
0x0000000001f09420> raised TypeError, but the exception message does not
                    match.

EXPECTED:
'NoneType' does not have the buffer interface

GOT:
Can't convert 'NoneType' object to str implicitly
----------------------------------------------------------------------

Signed-off-by: Austin Seipp <aseipp@pobox.com>
@FRidh
Copy link
Member

FRidh commented May 15, 2019

please report the issue upstream

@worldofpeace
Copy link
Contributor

ping @thoughtpolice

@thoughtpolice
Copy link
Member Author

Afraid I haven't had time to exactly write a good bug report for upstream as I've been busy for a few weeks (but I do still want this merged). Will try to get something reported soon.

@stale
Copy link

stale bot commented Jun 2, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@SuperSandro2000 SuperSandro2000 added 2.status: wait-for-upstream Waiting for upstream fix (or their other action). 9.needs: upstream fix labels Nov 28, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 28, 2020
@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
@Artturin
Copy link
Member

Artturin commented Feb 2, 2023

Reopen and rebase if you're still interested in this.

@Artturin Artturin closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: wait-for-upstream Waiting for upstream fix (or their other action). 6.topic: python 9.needs: upstream fix 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants