[wpt] Don't make unimplemented CSS properties PASS. #16845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 15, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1609850
branch
from
5e5cabe
to
cdfafbc
Compare
For computed style and inheritance tests, we silently passed unimplemented CSS properties. Assert that they exist, and if not, fail instead. R=ericwilligers@chromium.org Change-Id: I1f62bb2ef93b84528373b329dadefb6162ce19c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609850 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#660172}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1609850
branch
from
cdfafbc
to
bd6e8d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For computed style and inheritance tests, we silently passed
unimplemented CSS properties. Assert that they exist, and if not, fail
instead.
R=ericwilligers@chromium.org
Change-Id: I1f62bb2ef93b84528373b329dadefb6162ce19c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609850
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660172}