[IntersectionObserver] Fix target rect for block inside inline #16834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 14, 2019
As the spec requires, use the same logic as Element::getBoundingClientRect for the target rect. BUG=962605 R=eae@chromium.org Change-Id: Ib5aaec30d9de79901d08f8fe3ce0a3998468839f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612032 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#659836}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1612032
branch
from
0043a37
to
0c936a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the spec requires, use the same logic as
Element::getBoundingClientRect for the target rect.
BUG=962605
R=eae@chromium.org
Change-Id: Ib5aaec30d9de79901d08f8fe3ce0a3998468839f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612032
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659836}