[LayoutNG] Fix crash for very long line with break-word
#16847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 15, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1613138
branch
3 times, most recently
from
f3b37a5
to
15184fd
Compare
This patch fixes NGLineBreaker crash when handling a very long line. Because line breaker determines overflow by the position being larger than the available width, it cannot stop if the available width is |LayoutUnit::Max()|. This patch clamps the available width by |LayoutUnit::NearlyMax()| to prevent that. The `word-wrap: break-word` is not necessary to cause the failure, but it makes things worse by setting |ShapeResult| to |nullptr| when overflow occurs for the performance reason. This patch also changes |BreakText| to return whether the overflow occurred or not, rather than callers to determine it from the position. Doing so helps clearer communication with the callers. Bug: 961987 Change-Id: I17eb758aca8b9b6d3e2f328e5b1b49acb83c0a5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613138 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#660871}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1613138
branch
from
15184fd
to
3adfdc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes NGLineBreaker crash when handling a very
long line.
Because line breaker determines overflow by the position
being larger than the available width, it cannot stop if the
available width is |LayoutUnit::Max()|. This patch clamps the
available width by |LayoutUnit::NearlyMax()| to prevent that.
The
word-wrap: break-wordis not necessary to cause thefailure, but it makes things worse by setting |ShapeResult|
to |nullptr| when overflow occurs for the performance reason.
This patch also changes |BreakText| to return whether the
overflow occurred or not, rather than callers to determine it
from the position. Doing so helps clearer communication with
the callers.
Bug: 961987
Change-Id: I17eb758aca8b9b6d3e2f328e5b1b49acb83c0a5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613138
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660871}