Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSP430 debug stack #58600

Merged
merged 2 commits into from May 7, 2021
Merged

MSP430 debug stack #58600

merged 2 commits into from May 7, 2021

Conversation

AerialX
Copy link
Contributor

@AerialX AerialX commented Mar 31, 2019 •
edited

Motivation for this change

mspdebug has support for loading libmsp430.so at runtime to use TI's vendor driver for interfacing with debug/jtag hardware, which has better/additional support for their devices.

Questions
  • Is including the binary distribution appropriate here? It has additional proprietary support, is ahead of the open source release, but is kind of ugly and unfree. The idea is that if you need it, you can use pkgs.mspdebug.override { mspds = pkgs.mspds-bin; } to get it. Attempts to contact them about updating the open-source version were deflected.
  • enableMspds is currently ? false in mspdebug: darwin fixes and enableParallelBuilding #58598, so this won't be used by default. Would it make sense to change that default?
  • Is the patch alright? The package is messy vendor code based on an outdated boost and doesn't compile otherwise. There's some discussion on why it's necessary.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@AerialX AerialX force-pushed the msp430-mspds branch 3 times, most recently from 8b824f4 to 2df8184 Compare March 31, 2019 00:34
@AerialX AerialX mentioned this pull request Jul 2, 2019
Merged
10 tasks
@AerialX AerialX force-pushed the msp430-mspds branch 2 times, most recently from f4eed4c to 9443286 Compare July 2, 2019 21:16
@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@AerialX
Copy link
Contributor Author

AerialX commented Jun 2, 2020

Mean bot, it still merges fine :(

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@stale
Copy link

stale bot commented Jan 18, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 18, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 23, 2021
roberth
roberth approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long. It seems that the maintainers didn't know what to do at the time, because they want to do a good job and they don't know about this tool.
However, you're the maintainer, so we should trust that you know the tool and we should only have to review the Nix-specific aspects.
I hope we can be better at this, but please don't hesitate to ask for a review and merge on IRC, discourse, requesting a review on github, @ mentioning a nixpkgs committer, etc.

@roberth roberth merged commit f689955 into NixOS:master May 7, 2021
@AerialX AerialX deleted the msp430-mspds branch May 18, 2021 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberth roberth roberth approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AerialX @roberth @GrahamcOfBorg