Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm-pack: init at 0.8.1 #58644

Merged
merged 1 commit into from May 3, 2019
Merged

wasm-pack: init at 0.8.1 #58644

merged 1 commit into from May 3, 2019

Conversation

dhl
Copy link
Contributor

@dhl dhl commented Apr 1, 2019 •
edited

Motivation for this change

This pull request packages wasm-pack, which is an important part of the Rust-Wasm ecosystem to generate WebAssembly packages with JavaScript bindings.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

tadeokondrak
tadeokondrak approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@tadeokondrak tadeokondrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working

@dhl
Copy link
Contributor Author

dhl commented Apr 8, 2019

Hi @Mic92 and @LnL7. I saw that you are listed as the code owners for Rust. I'm wondering if you could check if this commit is merge-worthy, or point me to someone else who can help vet this.

Thanks so much!

LnL7
LnL7 reviewed Apr 8, 2019
View reviewed changes
pkgs/development/tools/wasm-pack/default.nix Outdated

cargoSha256 = "1xdx0gjqd4zyhnp72hz88rdmgry1m7rcw2j73lh67vp08z74y54y";

nativeBuildInputs = [ pkgconfig openssl ];
Copy link
Member

@LnL7 LnL7 Apr 8, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably links against openssl, in which case it should be in buildInputs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LnL7 yes indeed!

For cross-compilation, is this host/build distinction more significant than just for clarity?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LnL7 After re-reading the relevant sections of nixpkgs manual and observing the build result on darwin, I think I now understand the distinction between nativeBuildInputs and buildInputs.

In my latest change, I've put pkgconfig into naitveBuildInputs and openssl into buildInputs:

nativeBuildInputs = [ pkgconfig ];

buildInputs = [ openssl ];

Thanks again for reviewing this PR and suggesting changes.

Is there more work to be done to get this PR fit for merge?

@LnL7
Copy link
Member

LnL7 commented Apr 8, 2019

@GrahamcOfBorg build wasm-pack

@dhl
Copy link
Contributor Author

dhl commented Apr 9, 2019

Rebased master and squashed all changes into one commit.

@dhl dhl changed the title wasm-pack: init at 0.7.0 wasm-pack: init at 0.8.1 Apr 9, 2019
@dhl
wasm-pack: init at 0.8.1
419b7c6 
wasm-pack is a workflow tool maintained by the Rust and WebAssembly
Working Group to make working with Rust-generated WebAssembly packages
easier to work with.
@kevincox kevincox merged commit d30caa9 into NixOS:master May 3, 2019
@kevincox
Copy link
Contributor

kevincox commented May 3, 2019

Hmm, this failed once merged: https://hydra.nixos.org/build/93023162/nixlog/2

I'll see if there is a reason the hash was expected to change.

@matthewbauer
Copy link
Member

Yeah it looks like it's related to #60668

@kevincox
Copy link
Contributor

kevincox commented May 3, 2019

I've created #60892 to use the hydra hash. PTAL.

@dhl
Copy link
Contributor Author

dhl commented May 4, 2019

@kevincox thanks for sorting this out !

@dhl dhl deleted the wasm-pack branch May 24, 2019 15:43
@turboMaCk
Copy link
Member

I was about to open PR to add this. Pleased to see I don't have to <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 left review comments

@tadeokondrak tadeokondrak tadeokondrak approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@dhl @LnL7 @kevincox @matthewbauer @turboMaCk @tadeokondrak @infinisil @GrahamcOfBorg @Janik-Haag