Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mspdebug: darwin fixes and enableParallelBuilding #58598

Merged
merged 3 commits into from Jun 29, 2020

Conversation

AerialX
Copy link
Contributor

@AerialX AerialX commented Mar 30, 2019

Motivation for this change

I didn't realise enableParallelBuilding wasn't the default behaviour, and the build needed fixing on darwin. mspdebug's makefile attempts to detect whether homebrew/fink/macports is used on the system, so this kicks it down the right execution path.

Also includes a precursor to #58600, which allows for plugging in the msp debug stack into the binary's runtimepath (mspdebug uses dlopen to find the library). The derivations themselves are left to the other PR, since they may need more thorough review or may not be appropriate for inclusion in nixpkgs etc.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@AerialX
Copy link
Contributor Author

AerialX commented Jul 2, 2019

@Ericson2314 you reviewed the original PR that brought in this package, any chance of having time to look this and #58600 over or know someone who can? It's only tangentially related but not really sure who to poke as these have been sitting for a while.

@vcunat
Copy link
Member

vcunat commented Jul 2, 2019

Let me try the build at least.
@GrahamcOfBorg build mspdebug

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@AerialX
Copy link
Contributor Author

AerialX commented Jun 2, 2020

:(

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@ryantm
Copy link
Member

ryantm commented Jun 29, 2020

I don't understand all the changes here, but they are made by the maintainer, they seem innocuous, it builds, and it is a low impact dependecy-wise. Merging! Sorry it took so long to merge.

@ryantm ryantm merged commit cbb7c81 into NixOS:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants