New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mspdebug: darwin fixes and enableParallelBuilding #58598
Conversation
35447b7
to
e97d271
Compare
@Ericson2314 you reviewed the original PR that brought in this package, any chance of having time to look this and #58600 over or know someone who can? It's only tangentially related but not really sure who to poke as these have been sitting for a while. |
Let me try the build at least. |
e97d271
to
b31fd6d
Compare
Thank you for your contributions.
|
b31fd6d
to
5ba76e9
Compare
:( |
I don't understand all the changes here, but they are made by the maintainer, they seem innocuous, it builds, and it is a low impact dependecy-wise. Merging! Sorry it took so long to merge. |
Motivation for this change
I didn't realise
enableParallelBuilding
wasn't the default behaviour, and the build needed fixing on darwin. mspdebug's makefile attempts to detect whether homebrew/fink/macports is used on the system, so this kicks it down the right execution path.Also includes a precursor to #58600, which allows for plugging in the msp debug stack into the binary's runtimepath (mspdebug uses dlopen to find the library). The derivations themselves are left to the other PR, since they may need more thorough review or may not be appropriate for inclusion in nixpkgs etc.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)