Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gotop: 2.0.1 -> 3.0.0 #58615

Merged
merged 1 commit into from Apr 10, 2019
Merged

gotop: 2.0.1 -> 3.0.0 #58615

merged 1 commit into from Apr 10, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Mar 31, 2019

Motivation for this change

Changelog: https://github.com/cjbassi/gotop/blob/master/CHANGELOG.md#300---2019-02-22

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

matthiasbeyer
matthiasbeyer approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple version-hash bump.

@zookatron
Copy link
Contributor

I tested this change out on x86_64-linux, and it builds and runs without any issues for me. Despite the major version bump the changelog looks pretty minimal so this seems like a very low-risk change to merge in.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/17

@xeji xeji merged commit 1c17ccf into NixOS:master Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@marsam @zookatron @nixos-discourse @matthiasbeyer @infinisil @GrahamcOfBorg @xeji