Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitea: Fix sqlite support and baked-in tags #58584

Merged
merged 1 commit into from Mar 30, 2019
Merged

gitea: Fix sqlite support and baked-in tags #58584

merged 1 commit into from Mar 30, 2019

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Mar 30, 2019 •
edited

Motivation for this change

Fixes #58576
Also includes all the tags in --version.
Needs backport to 19.03, cc #56826

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb srhb requested a review from etu March 30, 2019 13:58
@srhb
Copy link
Contributor Author

srhb commented Mar 30, 2019

@GrahamcOfBorg test gitea.sqlite

@srhb srhb mentioned this pull request Mar 30, 2019
Closed
10 tasks
@srhb
Copy link
Contributor Author

srhb commented Mar 30, 2019

Nevermind, this doesn't actually need a backport unless we grab the PAM support too.

@Ma27
Copy link
Member

Ma27 commented Mar 30, 2019

Other than that, the change seems fine 👍

@Ma27 Ma27 mentioned this pull request Mar 30, 2019
Closed
10 tasks
@srhb
Copy link
Contributor Author

srhb commented Mar 30, 2019

@GrahamcOfBorg test gitea.sqlite

@Ma27 Ma27 merged commit b61fba0 into NixOS:master Mar 30, 2019
@Ma27
Copy link
Member

Ma27 commented Mar 30, 2019

@srhb thanks!

@srhb srhb deleted the gitea-tags-fix branch March 31, 2019 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu etu approved these changes

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@srhb @Ma27 @etu @GrahamcOfBorg