Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

josm: fix support for kendzi3d plugin #58617

Closed
wants to merge 1 commit into from

Conversation

jluttine
Copy link
Member

Motivation for this change

JOSM supports installing plugins from its own preferences. Apparently, we don't handle this on nixpkgs side but let JOSM handle those plugins. Kendzi3D plugin requires libXxf86vm to be on the library path. This fixes that. Not sure if this is the correct way to fix this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rycee
Copy link
Member

rycee commented Mar 31, 2019

This solution seems fair enough to me. Rebased to master in 005fb92. Thanks for the fix!

@rycee rycee closed this Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants