-
-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible GS issues in Scenario Editor #7131
Comments
GS interaction with the editor is weird in general and needs a major overhaul. |
This issue has been automatically marked as stale because it has not had any activity in the last two months. |
Partially addressed some of the issues in #7084 |
I know this is old, but I think the GS behavior with the scenario editor was fully defined with #10152, so this issue should be considered fixed. Before, it may have been ambiguous because you couldn't edit the GS fully in the scenario editor, yet loading a scenario would initialize the script. But now, since you can fully edit the GS in scenario editor, initializing GS when loading a scenario is intended behavior by definition; There's no longer any ambiguity in the interaction between GS and scenario editor. I didn't see this issue at the time, so forgot to label the commit as a fix. |
[00:28] Samu> I have a delicate situation on my hands: on 1.8.0 and master, GS can be edited in scenario editor with no visual indication of its instance being active or not
[00:29] Samu> my gui stuff exposes that loading a scenario, will always activate the GS
[00:29] Samu> even if i saved it as a configuration
[00:30] Samu> i don't think it's intended for it to load as active, if it wasn't saved as active
[00:30] Samu> but I'm not sure
[00:30] Samu> need your thoughts on it
[00:31] @peter1138> Nothing should really be active within the scenario editor.
[00:32] Samu> so, it's a bug? a very hidden one?
[00:34] Samu> how am I gonna report the steps for this... it's unnoticeable on 1.8.0
[00:35] @peter1138> Nobody cares about 1.8.0 :p
[00:35] Samu> okay, it's the same as current master
[00:35] Samu> unnoticeable, but it's there
[00:35] @peter1138> Anyway, I thought you said that it's your stuff that activates the GS.
[00:36] Samu> no, it's not activated by me
[00:36] @peter1138> 00:29 < Samu> my gui stuff exposes that loading a scenario, will always activate the GS
[00:36] Samu> i simply made the gui to be able to detect what's active, and it's how I spotted the bug
[00:36] @peter1138> Ok
[00:36] @peter1138> So by "active" what does it do?
[00:37] @peter1138> Actually run?
[00:37] Samu> the instance is running
[00:37] @peter1138> Maybe it is meant to run? I don't kno!
[00:37] @peter1138> +w
[00:37] Samu> doesn't seem to be doing anything
[00:37] Samu> but it's active
[00:37] Samu> the issue is that on master, the slot is always configurable, i can change to other gs
[00:38] Samu> that's gonna mix configs of GS's from each other
[00:39] Samu> saved data may be of one GS, but then loaded into the other, that's gonna conflict for sure and cause issues
Anyone with more expertise regarding this? What to do?
The text was updated successfully, but these errors were encountered: