Skip to content

pyre: 0.0.20 -> 0.0.22 #58618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2019
Merged

pyre: 0.0.20 -> 0.0.22 #58618

merged 2 commits into from
Apr 10, 2019
+38 −4

Conversation

teh
Copy link
Contributor

@teh teh commented Mar 31, 2019

Motivation for this change

Update pyre

Things done

NB - I only checked the pyre build. It's possible (likely?) that the base64 update will break other ocaml dependencies. I'll report back when nix-review finished on my laptop.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teh teh requested a review from FRidh as a code owner March 31, 2019 14:29
@teh
Copy link
Contributor Author

teh commented Mar 31, 2019 

11 package failed to build:
ocamlPackages.camlpdf ocamlPackages.cohttp ocamlPackages.cohttp-lwt ocamlPackages.cohttp-lwt-unix ocamlPackages.cpdf ocamlPackages.git-http ocamlPackages.git-unix ocamlPackages.monotoneViz ocamlPackages.piqi ocamlPackages.piqi-ocaml ocamlPackages.unison

Not all of those are related to B64 errors but most are. To avoid an update-fest I think I need to introduce 2 versions (2 and 3) of the base64 package.

@infinisil infinisil added the 8.has: package (update) This PR updates a package to a newer version label Apr 1, 2019
@ryantm
Copy link
Member

ryantm commented Apr 4, 2019

@GrahamcOfBorg build pyre ocamlPackages.base64

vbgl
vbgl previously requested changes Apr 6, 2019
View reviewed changes
pkgs/top-level/ocaml-packages.nix Outdated
@@ -55,6 +55,8 @@ let

base64 = callPackage ../development/ocaml-modules/base64 { };

base64_3_1_0 = callPackage ../development/ocaml-modules/base64/v3_1_0.nix { };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This attribute is too specific. base64_3 should be enough.

Also, I would rather like a specific name for the legacy version (base64_2).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I shuffled that around (base64_2 and the default is now version 3)

pkgs/development/ocaml-modules/base64/v3_1_0.nix Outdated

let version = "3.1.0"; in

stdenv.mkDerivation {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use buildDunePackage

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@vbgl vbgl mentioned this pull request Apr 6, 2019
Merged
10 tasks
@vbgl vbgl dismissed their stale review April 6, 2019 13:29

Suggested changes there: #59065

vbgl
vbgl requested changes Apr 6, 2019
View reviewed changes
pkgs/development/tools/pyre/default.nix Outdated
let
# Manually set version - the setup script requires
# hg and git + keeping the .git directory around.
pyre-version = "0.0.20"; # also change typeshed revision below with $pyre-src/.typeshed-version
pyre-version = "0.0.21"; # also change typeshed revision below with $pyre-src/.typeshed-version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 0.0.22 is out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, thanks!

@teh teh changed the title pyre: 0.0.20 -> 0.0.21 pyre: 0.0.20 -> 0.0.22 Apr 6, 2019
@pSub
Copy link
Member

pSub commented Apr 7, 2019

@teh I've merged #59065, so the new base64 is available.

teh added 2 commits April 9, 2019 22:19
@teh
python3Packages.xxhash: init at 1.3.0

Verified

This commit was signed with the committer’s verified signature. The key has expired.
jluttine Jaakko Luttinen
GPG key ID: 7B1CE13152E6B964
Expired
Verified
Learn about vigilant mode
efc0fc1
@teh
pyre: 0.0.20 -> 0.0.22
e6ebd05
@teh
Copy link
Contributor Author

teh commented Apr 9, 2019

@pSub Thanks! Rebased to remove my own base64 update.

@pSub pSub merged commit d1d0ab9 into NixOS:master Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@teh @ryantm @pSub @vbgl @infinisil @GrahamcOfBorg