Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: b556663201f0
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 4cd107f6b3e0
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Mar 3, 2019

  1. dlib: add flag to disable AVX support 

    Especially older hardware doesn't support AVX instructions. DLib is
still functional there, but significantly slower[1].

By setting `avxInstructions` to false, DLib will be compiled without
this feature.

[1] http://dlib.net/compile.html
    @Ma27
    Ma27 committed Mar 3, 2019
    Copy the full SHA
    9732c44 View commit details
    Browse the repository at this point in the history

  2. pythonPackages.face_recognition: 1.2.2 -> 1.2.3 

    There's no git tag for 1.2.3, hence we need to pin to the corresponding
revision because we build from a git source.

After recent breakage on Hydra[1], the tests were disabled. Although
some build machines don't support AVX, we shouldn't use a DLib without
AVX as the builder's result is also used on modern machines with AVX
support. Before merging changes, maintainers should run the check phase
locally in a `nix-shell`.

[1] https://hydra.nixos.org/build/89533530
    @Ma27
    Ma27 committed Mar 3, 2019
    Copy the full SHA
    6fec5aa View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2019

  1. Merge pull request #56786 from Ma27/dlib-avx-fixes 

    dlib: improve AVX configuration
    @Ma27
    Ma27 committed Mar 30, 2019
    Copy the full SHA
    4cd107f View commit details
    Browse the repository at this point in the history