Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I didn’t shoot the text caption #2115

Merged

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Mar 30, 2019

Without the check for component.name, we end up destroying the textCaption member of the MapNode (the hovertext), which is not what we want, and causes a MapView callback to systematically throw, preventing all nodes from ever being updated again.

@pleroy pleroy added the LGTM label Mar 30, 2019
@eggrobin eggrobin merged commit 43574f9 into mockingbirdnest:master Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants