Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZHF 19.03: backports FileSlurp update #58591

Merged
merged 2 commits into from Mar 30, 2019
Merged

ZHF 19.03: backports FileSlurp update #58591

merged 2 commits into from Mar 30, 2019

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Mar 30, 2019 •
edited

Motivation for this change

See #57977

The referenced commit by @srhb has been orphaned from its tree, and I didn't really know how to cherry-pick + attribute properly. I additionally removed the now unneeded file.

cc #56826

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

volth and others added 2 commits March 30, 2019 15:10
@samueldr
[cpan2nix] perlPackages.FileSlurp: 9999.25 -> 9999.26
0afebda 
(cherry picked from commit bba2eb9)
@samueldr
perlPackages.FileSlurp: remove obsolete patch
5894c3c 
FileSlurp no longer uses syswrite

cc @srhb as initial author:

 * NixOS@ce019a5
@samueldr
Copy link
Member Author

@GrahamcOfBorg build perldevelPackages.FileSlurp

@samueldr samueldr merged commit d6994e4 into NixOS:release-19.03 Mar 30, 2019
@samueldr samueldr deleted the zhf/file-slurp branch March 31, 2019 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samueldr @GrahamcOfBorg