Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edge_webdriver includes '\r' (CR) in some test names #16187

Closed
Hexcles opened this issue Apr 1, 2019 · 11 comments
Closed

edge_webdriver includes '\r' (CR) in some test names #16187

Hexcles opened this issue Apr 1, 2019 · 11 comments
Labels
infra priority:backlog

Comments

@Hexcles
Copy link
Member

Hexcles commented Apr 1, 2019 •
edited

Failure examples are mostly from WebCryptoAPI/generateKey, especially those with query params. e.g. successes_RSA-OAEP.https.any.html?1-10 becomes successes_RSA-OAEP.https.any.html?1-10\r in edge_webdriver.

This is preventing wpt.fyi from ingesting the run because GCS doesn't allow CR or LF in paths.

Also, this is the first time I see the error and there's been only one instance since we started running edge_webdriver. Here's the build: https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=11520 https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=12809&view=results
@Hexcles
Copy link
Member Author

Hexcles commented Apr 4, 2019

Raising to "urgent" as this is now always happening.

@Hexcles
Copy link
Member Author

Hexcles commented Apr 4, 2019

cc @foolip

@gsnedders
Copy link
Member

In the test names in wptreport.json?

@gsnedders
Copy link
Member

Looking at the wptreport.json data in https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=11520 I can't find successes_RSA-OAEP.https.any.html?1-10\r?

@Hexcles
Copy link
Member Author

Hexcles commented Apr 15, 2019 •
edited by gsnedders

@gsnedders yes, the "test" field in wptreport.json. That was probably a bad example; try searching for "successes_RSA-OAEP.https.any.html?101-110\r" (it's in wpt_report_16.json).

@gsnedders
Copy link
Member

gsnedders commented Apr 15, 2019 •
edited

I still can't find that in that Azure job? Only "test": "/WebCryptoAPI/generateKey/successes_RSA-OAEP.https.any.html?101-110"?

@Hexcles
Copy link
Member Author

Hexcles commented Apr 15, 2019

I might've lost myself among multiple Azure tabs and pasted the wrong link.

Here's a newer build where you can also see the issue: https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=12809&view=results

@Hexcles
Copy link
Member Author

Hexcles commented Apr 15, 2019

Found some stack trace when \r was seen in test names:

Unterminated string constant
Traceback (most recent call last):
  File "C:\Agent\_work\1\s\tools\wptrunner\wptrunner\executors\executorwebdriver.py", line 282, in _run
    self.result = True, self.func(self.protocol, self.url, self.timeout)
  File "C:\Agent\_work\1\s\tools\wptrunner\wptrunner\executors\executorwebdriver.py", line 358, in do_testharness
    self.script_resume % format_map, async=True)
  File "C:\Agent\_work\1\s\tools\wptrunner\wptrunner\executors\executorwebdriver.py", line 38, in execute_script
    return method(script)
  File "C:\Agent\_work\1\s\tools\webdriver\webdriver\client.py", line 20, in inner
    return func(self, *args, **kwargs)
  File "C:\Agent\_work\1\s\tools\webdriver\webdriver\client.py", line 642, in execute_async_script
    return self.send_session_command("POST", "execute/async", body)
  File "C:\Agent\_work\1\s\tools\webdriver\webdriver\client.py", line 508, in send_session_command
    return self.send_command(method, url, body)
  File "C:\Agent\_work\1\s\tools\webdriver\webdriver\client.py", line 472, in send_command
    raise err
JavascriptErrorException: javascript error (500): Unterminated string constant

@Hexcles
Copy link
Member Author

Hexcles commented Apr 15, 2019

FWIW, Edge stable on BuildBot is working fine: https://wpt.fyi/results/WebCryptoAPI/generateKey?q=successes_RSA-OAEP.https.any.html&run_id=5637912473370624&run_id=5103254845259776&run_id=5136145704812544&run_id=5729575162085376

Hexcles added a commit to web-platform-tests/wpt.fyi that referenced this issue Apr 18, 2019
@Hexcles
[processor] Strip whitespaces from test names
b8beed5 
Related to web-platform-tests/wpt#16187

We still don't know the root cause of the WPT issue, but we can work
around it from the wpt.fyi side.
@Hexcles Hexcles mentioned this issue Apr 18, 2019
Merged
lukebjerring pushed a commit to web-platform-tests/wpt.fyi that referenced this issue Apr 18, 2019
@Hexcles @lukebjerring
[processor] Strip whitespaces from test names (#1274)
2c0e943 
Related to web-platform-tests/wpt#16187

We still don't know the root cause of the WPT issue, but we can work
around it from the wpt.fyi side.
@Hexcles
Copy link
Member Author

Hexcles commented Apr 23, 2019

Downgrading this to backlog because although we haven't figured out why this is happening, it's been worked around on the wpt.fyi side by web-platform-tests/wpt.fyi#1274

@foolip
Copy link
Member

foolip commented May 6, 2021

This applies to EdgeHTML (Edge 12-18) which we're not running any longer, so no bugs around it are realistically ever going to be fixed. Closing.

@foolip foolip closed this as completed May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infra priority:backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gsnedders @foolip @Hexcles