Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qsynth: 0.5.2 -> 0.5.4 #58629

Closed
wants to merge 1 commit into from
Closed

Conversation

minijackson
Copy link
Member

Motivation for this change

QSynth 0.5.2 fails to compile for me now, presumably because of the incompatibility with fluidsynth >= 2.0.0.

The last version is actually 0.5.5 but I didn't manage to compile it because of this issue.

The previous issue with the desktop file was more "moved" than fixed ^^

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@minijackson
Copy link
Member Author

Closing, since b0fbc35 happened

@minijackson minijackson closed this Apr 9, 2019
@minijackson minijackson deleted the qsynth-0.5.4 branch April 10, 2019 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants