typora: 0.9.64 -> 0.9.68 #58601
Merged
typora: 0.9.64 -> 0.9.68 #58601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the wrapping happen in postFixup or else the wrapper is incomplete. That was noted in NixOS#56533 Closes NixOS#56533
|
Sorry for breakage! (I think it was me, but didn't check 😇)
Tested this, LGTM! Thanks!
On Sat, 30 Mar 2019 18:46:41 -0700, worldofpeace ***@***.***> wrote:
###### Commit Message
Make the wrapping happen in postFixup
or else the wrapper is incomplete.
That was noted in #56533
Closes #56533
###### Motivation for this change
Finish #56533
This fixes a crash (incomplete wrapper) so I will be porting to stable.
###### Things done
<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->
- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
- Built on platform(s)
- [x] NixOS
- [ ] macOS
- [ ] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
- [x] Tested execution of all binary files (usually in `./result/bin/`)
- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
- [ ] Assured whether relevant documentation is up to date
- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
---
cc @dtzWill
You can view, comment on, or merge this pull request online at:
#58601
-- Commit Summary --
* typora: 0.9.64 -> 0.9.68
-- File Changes --
M pkgs/applications/editors/typora/default.nix (34)
-- Patch Links --
https://github.com/NixOS/nixpkgs/pull/58601.patch
https://github.com/NixOS/nixpkgs/pull/58601.diff
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#58601
Non-text part: text/html
|
Oh no it was me. But we're peaceful with the postmortems 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message
Make the wrapping happen in postFixup
or else the wrapper is incomplete.
That was noted in #56533
Closes #56533
Motivation for this change
Finish #56533
This fixes a crash (incomplete wrapper) so I will be porting to stable.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)cc @dtzWill