Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pioneer: update to 20190203 #58682

Merged
merged 1 commit into from May 16, 2019
Merged

pioneer: update to 20190203 #58682

merged 1 commit into from May 16, 2019

Conversation

marius851000
Copy link
Contributor

Motivation for this change

An update is availaible for this game (exacly 1 year of difference, day by day)

There are also a switch to CMake

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

aanderse
aanderse requested changes Apr 11, 2019
View reviewed changes
pkgs/games/pioneer/default.nix Outdated Show resolved Hide resolved
pkgs/games/pioneer/default.nix Outdated Show resolved Hide resolved
pkgs/games/pioneer/default.nix Outdated Show resolved Hide resolved
pkgs/games/pioneer/default.nix Outdated Show resolved Hide resolved
@aanderse
Copy link
Member

@marius851000 Any interest in continuing this PR?

@marius851000
Copy link
Contributor Author

@aanderse I haven't seen there were a review here.

aanderse
aanderse requested changes May 13, 2019
View reviewed changes
pkgs/games/pioneer/default.nix Outdated Show resolved Hide resolved
@aanderse
Copy link
Member

@marius851000 No problem. You should maybe double check your github notifications on this PR. I left one more review.

@marius851000
Copy link
Contributor Author

@aanderse that's done. Thank for reviewing my code.

@aanderse
Copy link
Member

@GrahamcOfBorg build pioneer

aanderse
aanderse requested changes May 14, 2019
View reviewed changes
pkgs/games/pioneer/default.nix Outdated Show resolved Hide resolved
@aanderse
Copy link
Member

@marius851000 Final change and we're good to merge.

@marius851000
Copy link
Contributor Author

@aanderse done, thnak.

@aanderse
Copy link
Member

@GrahamcOfBorg build pioneer

@aanderse aanderse merged commit ac9b132 into NixOS:master May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse requested changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marius851000 @aanderse @infinisil @GrahamcOfBorg