Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] postfix: 3.3.3 -> 3.3.4 #58680

Merged
merged 1 commit into from Apr 5, 2019
Merged

[18.09] postfix: 3.3.3 -> 3.3.4 #58680

merged 1 commit into from Apr 5, 2019

Conversation

dotlambda
Copy link
Member

Motivation for this change

http://www.postfix.org/announcements/postfix-3.4.5.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from xeji April 4, 2019 19:06
@xeji
Copy link
Contributor

xeji commented Apr 4, 2019

@GrahamcOfBorg test dovecot

@xeji
Copy link
Contributor

xeji commented Apr 4, 2019

The build failure on aarch64 seems looks like this postfix version doesn't know about linux 5 yet:

ATTENTION: Unknown system type: Linux 5.0.2

My guess it's related to using an older version of autotools. So postfix might not compile on systems running a linux 5 kernel, maybe on x86 as well. But that shouldn't keep us from merging because the same issue is likely to occur with postfix 3.3.3.

@dotlambda dotlambda merged commit 2229509 into NixOS:release-18.09 Apr 5, 2019
@dotlambda dotlambda deleted the postfix-3.3.4 branch April 5, 2019 08:07
@dotlambda
Copy link
Member Author

Let's hope Hydra can build it just fine and revert otherwise.

@dotlambda
Copy link
Member Author

Seems to work just fine: https://hydra.nixos.org/build/91619949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

@rickynils rickynils Awaiting requested review from rickynils

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @xeji @infinisil @GrahamcOfBorg