Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gildas: update to 20190401_a #58676

Merged
merged 1 commit into from Apr 10, 2019
Merged

gildas: update to 20190401_a #58676

merged 1 commit into from Apr 10, 2019

Conversation

smaret
Copy link
Member

@smaret smaret commented Apr 1, 2019 •
edited

Motivation for this change

Update gildas to the latest upstream version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Apr 2, 2019

@GrahamcOfBorg build gildas

1 similar comment
@smaret
Copy link
Member Author

smaret commented Apr 10, 2019

@GrahamcOfBorg build gildas

@smaret
Copy link
Member Author

smaret commented Apr 10, 2019

The build timed-out on x86_64-darwin and x86_64-linux, but I built the package successfully on my local linux and darwin machines.

@xeji
Copy link
Contributor

xeji commented Apr 10, 2019

Good enough to merge 😄

@xeji xeji merged commit cc118b4 into NixOS:master Apr 10, 2019
@smaret smaret deleted the gildas-update branch April 10, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smaret @xeji @infinisil @GrahamcOfBorg