- Commit messages should use "nixos/<module name>: <action>" format. - 4cd3e6c needs ```diff - (mkRenamedOptionModule [ "sound" "enableMediaKeys" ] [ "sound" "mediaKeys" "enable" ]) + (mkRenamedOptionModule [ "sound" "enableMediaKeys" ] [ "services" "actkbd" "volumeControl" "enable" ]) ``` to work properly else very old configurations will break. - 4cd3e6c also changes the semantics of the renamed options, enabling `sound.mediaKeys.enable` enabled `services.actkbd.enable` before, now it does not. To make this way of doing things work you would have to make `services.actkbd.enabled` depend on `volumeControl.enable`, as ugly as it sounds. In which case I would also suggest making `sound.mediaKeys` an alias to `services.actkbd.volumeControl` instead of `mkRenamedOptionModule`, since it makes sense to keep that option there for documentation purposes at the very least. But, personally, I'm 👎 on that patch in the first place. I think keeping these things outside of `actkbd` makes more sense since you could do the same thing using different backends. E.g. PulseAudio could have its own media keys setup with `actkbd` using `pauvcontrol` or whatever. I planned `actkbd` module as a generic modular thing, not as a place to assemble all possible implementations of all possible things, which this patch drives towards. - `brightness.sh` needs some more hacking, e.g. on my laptop `ls /sys/class/backlight` gives several results (it gives both acpi backlight and intel backlight controls), I think that script will do something bad in such a situation. I would consider using some lightweight tool for that instead. E.g. I use `pkgs.light`. Which brings me to `programs.light` option. I would just add the new options to that module instead and keep `actkbd` as module as it is.