Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hol_light: 2018-09-30 -> 2019-03-27 #58610

Merged
merged 2 commits into from Apr 6, 2019
Merged

hol_light: 2018-09-30 -> 2019-03-27 #58610

merged 2 commits into from Apr 6, 2019

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Mar 31, 2019

Motivation for this change

Compatibility with Camlp5-7.07

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

maggesi
maggesi approved these changes Mar 31, 2019
View reviewed changes
Copy link
Contributor

@maggesi maggesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

nice that we can finally get rid of the old version of camlp5.

@vbgl vbgl merged commit 0c09547 into NixOS:master Apr 6, 2019
@vbgl vbgl deleted the hol_light-2019-03-27 branch April 6, 2019 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maggesi maggesi maggesi approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @maggesi @GrahamcOfBorg