Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpPackages.phpc(s|bf): 3.4.0 -> 3.4.1 #58574

Merged
merged 2 commits into from Mar 31, 2019
Merged

phpPackages.phpc(s|bf): 3.4.0 -> 3.4.1 #58574

merged 2 commits into from Mar 31, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented Mar 30, 2019 •
edited

Motivation for this change

Changelog: https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.4.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Mar 31, 2019

Built and tested locally 👍

@Ma27 Ma27 merged commit 22c2284 into NixOS:master Mar 31, 2019
@Ma27
Copy link
Member

Ma27 commented Mar 31, 2019

@etu thanks!

@etu etu deleted the update-phpcs branch March 31, 2019 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@etu @Ma27 @infinisil @GrahamcOfBorg