Skip to content

stupidterm: 2018-09-25 -> 2019-03-26 #58572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2019
Merged

stupidterm: 2018-09-25 -> 2019-03-26 #58572

merged 1 commit into from
Mar 30, 2019
+10 −16

Conversation

etu
Copy link
Contributor

@etu etu commented Mar 30, 2019

Motivation for this change

Update contains clearing of urgency hint and they started shipping
their own .desktop file, so we switched to using that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@etu
stupidterm: 2018-09-25 -> 2019-03-26
686da10 
Update contains clearing of urgency hint and they started shipping
their own .desktop file, so we switched to using that.
@etu etu force-pushed the update-stupidterm branch from b8f67d2 to 686da10 Compare March 30, 2019 10:05
@GrahamcOfBorg GrahamcOfBorg added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 30, 2019
@infinisil infinisil added the 8.has: package (update) This PR updates a package to a newer version label Mar 30, 2019
@infinisil infinisil merged commit d55a6f2 into NixOS:master Mar 30, 2019
@etu etu deleted the update-stupidterm branch March 31, 2019 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @infinisil @GrahamcOfBorg