Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7433: don't use AirportSpec substitute if it's not set #7435

Merged
merged 1 commit into from Mar 30, 2019

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Mar 29, 2019

Maybe not the right fix, but it works.
I think subst_id can never be AT_INVALID, because default value for OverrideManagerBase::mappingID[].substitute_id is 0. But defaulting substitute_id to invalid_ID will probably need a savegame conversion, and I don't know if changing default substitute value for other managers will break stuff.

@glx22 glx22 merged commit e936305 into OpenTTD:master Mar 30, 2019
@planetmaker planetmaker added the backport requested This PR should be backport to current release (RC / stable) label Apr 6, 2019
PeterN pushed a commit to PeterN/OpenTTD that referenced this pull request Apr 8, 2019
@PeterN PeterN added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 8, 2019
@glx22 glx22 deleted the fix7433 branch April 11, 2019 13:51
douiwby pushed a commit to douiwby/OpenTTD that referenced this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants