Fix #7433: don't use AirportSpec substitute if it's not set #7435
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michicc
approved these changes
Mar 30, 2019
planetmaker
added
the
backport requested
PeterN
pushed a commit
to PeterN/OpenTTD
that referenced
this pull request
Apr 8, 2019
PeterN
pushed a commit
that referenced
this pull request
Apr 8, 2019
PeterN
added
backported
douiwby
pushed a commit
to douiwby/OpenTTD
that referenced
this pull request
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe not the right fix, but it works.
I think
subst_idcan never be AT_INVALID, because default value forOverrideManagerBase::mappingID[].substitute_idis 0. But defaultingsubstitute_idtoinvalid_IDwill probably need a savegame conversion, and I don't know if changing default substitute value for other managers will break stuff.