Skip to content

pythonPackages.jsbeautifier: 1.8.9 -> 1.9.1 #58632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2019
Merged

pythonPackages.jsbeautifier: 1.8.9 -> 1.9.1 #58632

merged 2 commits into from
Apr 7, 2019
+14 −6

Conversation

apeyroux
Copy link
Member

Motivation for this change

Up and "fix" #58608. I use doCheck = false; because there is a bug in the jsb test suite (cf #58608). It will have to be reactivated when the bug is fixed. I took the opportunity to upgrade.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@apeyroux apeyroux requested a review from FRidh as a code owner March 31, 2019 19:10
@infinisil infinisil added the 8.has: package (update) This PR updates a package to a newer version label Apr 1, 2019
@kalbasit kalbasit self-requested a review April 1, 2019 03:55
@kalbasit kalbasit self-assigned this Apr 1, 2019
@kalbasit
Copy link
Member

kalbasit commented Apr 1, 2019

I would also make a commit that fixes the tests and another for the update.

@dotlambda dotlambda changed the title jsbeautifier: 1.8.9 -> 1.9.1 pythonPackages.jsbeautifier: 1.8.9 -> 1.9.1 Apr 1, 2019
dotlambda
dotlambda requested changes Apr 1, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the commit message.

@apeyroux apeyroux force-pushed the up-jsbeautifier-191 branch from 22234fb to bf4209b Compare April 1, 2019 17:21
@apeyroux apeyroux force-pushed the up-jsbeautifier-191 branch 3 times, most recently from 61ba967 to 7e4160d Compare April 4, 2019 09:02
@apeyroux
Copy link
Member Author

apeyroux commented Apr 4, 2019

@GrahamcOfBorg build pythonPackages.jsbeautifier

@apeyroux
Copy link
Member Author

apeyroux commented Apr 4, 2019

ping @FRidh

@kalbasit
Copy link
Member

kalbasit commented Apr 4, 2019

@GrahamcOfBorg build pythonPackages.jsbeautifier

kalbasit
kalbasit requested changes Apr 4, 2019
View reviewed changes
Copy link
Member

@kalbasit kalbasit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is failing on Darwin.

EDIT: The build is failing because you are trying to modify a patch that was downloaded with fetchpatch. fetchpatch is just another derivation, and the $out of it is immutable.

@apeyroux apeyroux force-pushed the up-jsbeautifier-191 branch 2 times, most recently from c460306 to f377284 Compare April 4, 2019 19:56
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.jsbeautifier python3.pkgs.jsbeautifier

@kalbasit
Copy link
Member

kalbasit commented Apr 4, 2019

Please split the commit into 2 commits. One that fixes the build (it should apply to current version), and another for the update. Thanks!

@apeyroux apeyroux force-pushed the up-jsbeautifier-191 branch from f377284 to 322787c Compare April 5, 2019 19:47
pythonPackages.jsbeautifier: fix build (NixOS#58608)

Verified

This commit was signed with the committer’s verified signature.
vcunat Vladimír Čunát
GPG key ID: E747DF1F9575A3AA
Verified
Learn about vigilant mode
946807c
pythonPackages.jsbeautifier: 1.8.9 -> 1.9.1

Verified

This commit was signed with the committer’s verified signature.
vcunat Vladimír Čunát
GPG key ID: E747DF1F9575A3AA
Verified
Learn about vigilant mode
72c24b1
@apeyroux apeyroux force-pushed the up-jsbeautifier-191 branch from 322787c to 72c24b1 Compare April 5, 2019 20:02
@kalbasit
Copy link
Member

kalbasit commented Apr 6, 2019

@GrahamcOfBorg build python2.pkgs.jsbeautifier python3.pkgs.jsbeautifier

@flokli
Copy link
Contributor

flokli commented Apr 7, 2019

built and beautified some javascript, locally.

@flokli flokli merged commit fb3fcca into NixOS:master Apr 7, 2019
@flokli
Copy link
Contributor

flokli commented Apr 7, 2019

backported to 19.03 in dda301d and 971e516.

@flokli flokli mentioned this pull request Apr 7, 2019
Closed
@apeyroux apeyroux deleted the up-jsbeautifier-191 branch April 7, 2019 15:56
@apeyroux apeyroux restored the up-jsbeautifier-191 branch April 8, 2019 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda

@kalbasit kalbasit

@FRidh FRidh

Assignees

@kalbasit kalbasit

Labels
6.topic: python 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@apeyroux @kalbasit @dotlambda @flokli @infinisil @GrahamcOfBorg