Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browserpass: 2.0.22 -> 3.0.1 #58639

Merged
merged 2 commits into from Apr 1, 2019
Merged

browserpass: 2.0.22 -> 3.0.1 #58639

merged 2 commits into from Apr 1, 2019

Conversation

infinisil
Copy link
Member

Motivation for this change

This is a incompatible release, but I made this backwards compatible by including both the old and the new version in the package. People should already be able to update to this version, making the new version sit idly until the browser extension automatically updates in the following weeks, at which point the new version kicks in and the old one won't be needed anymore. Then we can remove v2 from the code.

As a consequence, this should be merged asap and backported to at least 19.03, such that the update gets to the channels before the browser extension auto-updates, otherwise it will break for everybody.

See browserpass/browserpass-native#31 as well

Something that needs to be updated yet is the home-manager module, ping @dermetfan

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size: 301MB -> 304MB
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil infinisil mentioned this pull request Mar 31, 2019
Merged
@infinisil
browserpass: 2.0.22 -> 3.0.1
6104fba 
See browserpass/browserpass-native#31

This is fully backwards compatible.
@infinisil
nixos/browserpass: update for v3
e98ee8d 
See browserpass/browserpass-native#31

Additionally browserpass was removed from systemPackages, because it
doesn't need to be installed, browsers will get the path to the binary
from the native messaging host JSON.
@infinisil infinisil merged commit 86956b9 into NixOS:master Apr 1, 2019
@infinisil infinisil deleted the update/browserpass branch April 1, 2019 15:31
@infinisil
Copy link
Member Author

infinisil commented Apr 1, 2019 •
edited

This needs to be backported, because as explained above, browserpass would just start to fail once the browser extension auto-updates. This is a preliminary fix if you will.

Backported to 19.03 in 7e889fe (and parent)
Backported to 18.09 in b791044 (and parent)

infinisil added a commit that referenced this pull request Apr 2, 2019
@infinisil
browserpass: Fix evaluation
58fbebc 
When I backported #58639 to 18.09,
I didn't realize that buildGoPackage still required the `name`
attribute. Thanks to @primeos for notifying me of this.
@ashkitten ashkitten mentioned this pull request Apr 14, 2019
Closed
infinisil added a commit to infinisil/nixpkgs that referenced this pull request Apr 26, 2019
@infinisil
browserpass: Remove v2 and switch to buildGoModule
01f443d 
See NixOS#58639
@infinisil infinisil mentioned this pull request Apr 26, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@infinisil @GrahamcOfBorg