Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hivex for darwin #58638

Merged
merged 1 commit into from Apr 17, 2019
Merged

Fix hivex for darwin #58638

merged 1 commit into from Apr 17, 2019

Conversation

Amar1729
Copy link
Contributor

@Amar1729 Amar1729 commented Mar 31, 2019 •
edited

Motivation for this change

Hivex library updated to work on macOS:

  • added libiconv dependency
  • added proper PERL5LIB to wrapper for hivexregedit

Mostly added this because it's a dependency for libguestfs which I'm still trying to get working on darwin. Haven't been able to find a lot of test cases for it though.

Had some help from rycee on the nixos irc for the perl stuff too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Mar 31, 2019
@Amar1729 Amar1729 changed the title added perl dep, added libiconv for macOS Fix hivex for darwin Mar 31, 2019
@xeji
Copy link
Contributor

xeji commented Apr 13, 2019

@GrahamcOfBorg build hivex

@Amar1729
Copy link
Contributor Author

Current build failure due to #59450

rip darwin :/

@Amar1729
Copy link
Contributor Author

am i allowed to ask grahamc to build things? also is there a way to specify building on darwin only?

@xeji
Copy link
Contributor

xeji commented Apr 15, 2019

am i allowed to ask grahamc to build things?

Unfortunately not (yet). Authorization is usually given to frequent contributors.

also is there a way to specify building on darwin only?

Such a feature has been discussed but (at least to my knowledge) not yet implemented.

@xeji
Copy link
Contributor

xeji commented Apr 15, 2019

So let's try again
@GrahamcOfBorg build hivex

@LnL7 LnL7 merged commit 698af96 into NixOS:master Apr 17, 2019
@LnL7 LnL7 added the 8.has: port to stable A PR already has a backport to the stable release. label Apr 17, 2019
@Amar1729 Amar1729 deleted the darwin-fix/hivex branch April 18, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Amar1729 @xeji @LnL7 @GrahamcOfBorg