Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.mutter328: use gnome-3-28 branch #58641

Merged
merged 3 commits into from Apr 3, 2019
Merged

gnome3.mutter328: use gnome-3-28 branch #58641

merged 3 commits into from Apr 3, 2019

Conversation

worldofpeace
Copy link
Contributor

Commit Message

Probably should get these patches in while
I'm stuck with this. Alternative would be to
fetch the patches individually.

pipewire was accidentally in buildInputs when it has
been disabled.

Changes: https://gitlab.gnome.org/GNOME/mutter/compare/3.28.3...gnome-3-28

Motivation for this change

The usual 馃槃

This also has a patch to hardcode the path to zenity.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
gnome3.mutter328: use gnome-3-28 branch
874856a 
Probably should get these patches in while
I'm stuck with this. Alternative would be to
fetch the patches individually.

pipewire was accidentally in buildInputs when it has
been disabled

Changes: https://gitlab.gnome.org/GNOME/mutter/compare/3.28.3...gnome-3-28
@worldofpeace
gnome3.mutter328: hardcode path to zenity
c4df832
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Mar 31, 2019
@worldofpeace worldofpeace merged commit d956f22 into NixOS:master Apr 3, 2019
@worldofpeace worldofpeace deleted the mutter328/use-gnome-3-28-branch branch April 3, 2019 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @GrahamcOfBorg