Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] gnome3.geary: make geary-attach executable #58642

Merged
merged 2 commits into from Apr 3, 2019
Merged

[19.03] gnome3.geary: make geary-attach executable #58642

merged 2 commits into from Apr 3, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Or else it doesn't get wrapped or get its shebang fixed up all pretty.

Fix is only for 19.03 because #57027 (it's already fixed there too)

Also has 940bb92 because it should be safe and I might as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace added the 8.has: port to stable A PR already has a backport to the stable release. label Apr 1, 2019
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Apr 1, 2019
@worldofpeace worldofpeace merged commit 91fa699 into NixOS:release-19.03 Apr 3, 2019
@worldofpeace worldofpeace deleted the geary/fix-attach branch April 3, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @GrahamcOfBorg @dtzWill