Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tokei: 9.0.0 -> 9.1.1 #58583

Merged
merged 1 commit into from Mar 30, 2019
Merged

tokei: 9.0.0 -> 9.1.1 #58583

merged 1 commit into from Mar 30, 2019

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Mar 30, 2019

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@gebner
Copy link
Member

gebner commented Mar 30, 2019

LGTM. Do you know what is up with the name change?

@gebner gebner merged commit 05d15b1 into NixOS:master Mar 30, 2019
@dywedir
Copy link
Member Author

dywedir commented Apr 2, 2019

The only thing I know is that Aaronepower and XAMPPRocky are the same person

@dywedir dywedir deleted the tokei branch April 2, 2019 18:16
@gebner
Copy link
Member

gebner commented Apr 2, 2019

@dywedir Thanks for clearing this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dywedir @gebner @infinisil @GrahamcOfBorg