Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

semver-tool: init at 2.1.0 #58581

Merged
merged 1 commit into from Mar 31, 2019
Merged

semver-tool: init at 2.1.0 #58581

merged 1 commit into from Mar 31, 2019

Conversation

matthiasbeyer
Copy link
Contributor

Cherry-picked from: alyssais@eeb1751
Although fixed so that it actually builds.

Motivation for this change

Closes: #50945
Superceeds and closes: #51004

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

just noting that alyssais fixed the hardcoded install path in

@worldofpeace
Copy link
Contributor

Testing this locally now.

worldofpeace
worldofpeace approved these changes Mar 31, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Played with some versions(all commands) locally and the output of
--version and --help look right.

Just needs to be squashed.

@alyssais @matthiasbeyer
semver-tool: init at 2.1.0
98c22f2 
Cherry-picked from: alyssais@eeb1751
Although fixed so that it actually builds.

Original message:

> I chose "semver-tool" as the path for this package because "semver" is
> extremely generic, and probably more rightly belongs to node-semver[1]
> (at least judging by GitHub stars), and because "semver-tool" is the
> name of this project's GitHub repository, and because it was the name
> used in the package request[2].
>
> Closes NixOS#50945.
>
> [1]: https://github.com/npm/node-semver
> [2]: NixOS#50945

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Copy link
Contributor Author

Here we go.

@worldofpeace worldofpeace merged commit d8c7f0b into NixOS:master Mar 31, 2019
@worldofpeace
Copy link
Contributor

Thanks @matthiasbeyer for fixing this and @alyssais for the original work ❇️

@matthiasbeyer matthiasbeyer deleted the add-semver-tool branch November 9, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@alyssais alyssais Awaiting requested review from alyssais

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: semver-tool
4 participants
@matthiasbeyer @worldofpeace @GrahamcOfBorg @alyssais