Feature: Per-group wagon removal flag #7441
Merged
+81
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michicc
reviewed
Mar 30, 2019
michicc
reviewed
Mar 30, 2019
| @@ -65,6 +65,7 @@ struct GroupStatistics { | |||
|
|
|||
| enum GroupFlags : uint8 { | |||
| GF_REPLACE_PROTECTION, ///< If set to true, the global autoreplace has no effect on the group | |||
| GF_END, | |||
There was a problem hiding this comment.
Put in a comment that CmdSetGroupFlag is currently limited to 3 bits?
There was a problem hiding this comment.
Hmm, yeah, this is wrong as I used GroupFlags as the storage type but the values within the enum are used to set bits. Perhaps it should be:
enum GroupFlag { ... }
typedef uint8 GroupFlags
or something.
michicc
reviewed
Mar 30, 2019
PeterN
force-pushed
the
per-group-wagon-removal
branch
from
481ed27 to
c1f356c
Compare
PeterN
force-pushed
the
per-group-wagon-removal
branch
from
c1f356c to
08d18c7
Compare
LordAro
requested changes
Jun 29, 2019
TrueBrain
added
candidate: yes
|
+1 to this one, I believe it's a straightforward improvement. |
PeterN
force-pushed
the
per-group-wagon-removal
branch
from
08d18c7 to
9ab09d9
Compare
|
Resurrected. Storage type of group::flags is changed to uint8 as it is a bit-field, not directly GroupFlags. |
michicc
reviewed
Apr 7, 2021
glx22
reviewed
Apr 7, 2021
PeterN
force-pushed
the
per-group-wagon-removal
branch
from
9ab09d9 to
1e36293
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #5730.
Group::replace_protection is converted to a bitmap of flags.
Savegame conversion is there just to set the flag for existing groups for compatibility.