Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/rename: drop system.nixos.{stateVersion, defaultChannel} #58596

Merged
merged 1 commit into from Mar 31, 2019
Merged

nixos/rename: drop system.nixos.{stateVersion, defaultChannel} #58596

merged 1 commit into from Mar 31, 2019

Conversation

worldofpeace
Copy link
Contributor

Comment said to remove these before 18.09 was released :(

Motivation for this change

I'm not sure if the comment in the file isn't valid anymore?
But I'm guessing we should remove these now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
nixos/rename: drop system.nixos.{stateVersion, defaultChannel}
ffd2e9b 
Comment said to remove these before 18.09 was released :(
@samueldr
Copy link
Member

cc @lheckemann RM for 19.09, just in case, but it's probably fine to remove.

From memory it was because for a short while between 18.03 and 18.09, unstable users could have built a system with a now reverted change for the option name. For reference, it starts with good intentions in #39447

@worldofpeace
Copy link
Contributor Author

From memory it was because for a short while between 18.03 and 18.09, unstable users could have built a system with a now reverted change for the option name. For reference, it starts with good intentions in #39447

Yep, I recall that. Shouldn't be a problem for us to drop this in 19.03 also.

@worldofpeace
Copy link
Contributor Author

Going for it

@worldofpeace worldofpeace merged commit 7a8d8e9 into NixOS:master Mar 31, 2019
@worldofpeace worldofpeace deleted the nixos-stateversion-drop branch March 31, 2019 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr samueldr approved these changes

@flokli flokli flokli approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @samueldr @flokli @GrahamcOfBorg