I don't think vendoring moretea/yarn2nix this is the right approach.

Can't you just use https://github.com/Profpatsch/yarn2nix and the required dependencies in a nix expression?

I guess @Profpatsch will gladly help in case you encounter issues with using that :-)

@flokli wrote:

I don't think vendoring moretea/yarn2nix this is the right approach.

Can't you just use https://github.com/Profpatsch/yarn2nix and the required dependencies in a nix expression?

I guess @Profpatsch will gladly help in case you encounter issues with using that :-)

Wouldn't it be the same?

From https://github.com/Profpatsch/yarn2nix#using-the-generated-nix-files-to-build-a-project:

  nixLib = pkgs.callPackage /path/to/yarn2nix/nix-lib {
    # WARNING (TODO): for now you need to use this checked out yarn2nix
    # because the upstream package (in haskellPackages) might have
    # broken dependencies (yarn-lock and yarn2nix are not in stackage)

Thanks @pacien for following up so quickly.

Wouldn't it be the same?

From https://github.com/Profpatsch/yarn2nix#using-the-generated-nix-files-to-build-a-project:

Yeah that sounds identical to what's done here. Though I'm not familiar with these tools, so my opinion won't be influential.

Yeah, it’s essentially the same. If yarn2nix already works for you, vendoring might be the best solution for now.

I’m not exactly sure why nomeata’s version was pulled from nixpkgs, but I could think about upstreaming my library to nixpkgs & make it beta. Next problem: I use hnix which is regularly broken sadly :(

@Profpatsch wrote:

[…] I could think about upstreaming my library to nixpkgs & make it beta. Next problem: I use hnix which is regularly broken sadly :(

If that's not possible, I think it would be very nice to have at least a common yarn2nix/nix-lib somewhere in nixpkgs. This would help a lot on its own.

yarn2nix/nix-lib somewhere in nixpkgs

At least for my implementation, the library is bound to the version of the tool (because changes normally propagate though to the library). Bear in mind that nomeata/yarn2nix and Profpatsch/yarn2nix only share their name, but are not compatible in any way.

So I'm not seeing anything raised that @pacien can make an action on, so I'm partial to this being merged.

If I don't get a counterargument in a couple of days I will merge this.