Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hydra: fix build #58592

Merged
merged 1 commit into from Mar 30, 2019
Merged

hydra: fix build #58592

merged 1 commit into from Mar 30, 2019

Conversation

danbst
Copy link
Contributor

@danbst danbst commented Mar 30, 2019 •
edited

Apply patch from NixOS/hydra#648
This patch only affects tests in checkPhase, so nothing should change in runtime.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danbst danbst requested a review from flokli March 30, 2019 20:25
@GrahamcOfBorg GrahamcOfBorg requested a review from Ma27 March 30, 2019 20:36
flokli
flokli approved these changes Mar 30, 2019
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strong 👍

@danbst danbst merged commit 8e18f4e into NixOS:master Mar 30, 2019
@danbst danbst deleted the hydra-build-fix branch March 30, 2019 20:57
@Ma27
Copy link
Member

Ma27 commented Mar 30, 2019

Ok, I was too slow, but also a 👍 from me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli approved these changes

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danbst @Ma27 @flokli @GrahamcOfBorg