Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flexget: 2.17.20 -> 2.20.17 #58690

Merged
merged 4 commits into from Apr 5, 2019
Merged

Conversation

dotlambda
Copy link
Member

Motivation for this change

use python37

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @sjau @agentpt5

@dotlambda dotlambda requested a review from FRidh as a code owner April 1, 2019 15:32
@dotlambda
Copy link
Member Author

This breaks a test of python2.pkgs.cherrypy. I have no idea why.

=================================== FAILURES ===================================
__________________________ BusMethodTests.test_block ___________________________

self = <cherrypy.test.test_bus.BusMethodTests testMethod=test_block>

    def test_block(self):
        b = wspbus.Bus()
        self.log(b)

        def f():
            time.sleep(0.2)
            b.exit()

        def g():
            time.sleep(0.4)
        threading.Thread(target=f).start()
        threading.Thread(target=g).start()
        threads = [t for t in threading.enumerate() if not t.daemon]
        self.assertEqual(len(threads), 3)

        b.block()

        # The block method MUST wait for the EXITING state.
        self.assertEqual(b.state, b.states.EXITING)
        # The block method MUST wait for ALL non-main, non-daemon threads to
        # finish.
        threads = [t for t in threading.enumerate() if not t.daemon]
        self.assertEqual(len(threads), 1)
        # The last message will mention an indeterminable thread name; ignore
        # it
        self.assertEqual(self._log_entries[:-1],
                         ['Bus STOPPING', 'Bus STOPPED',
                          'Bus EXITING', 'Bus EXITED',
>                         'Waiting for child threads to terminate...'])
E       AssertionError: Lists differ: ['Bus STOPPING', 'Bus STOPPED'... != ['Bus STOPPING', 'Bus STOPPED'...
E
E       First differing element 3:
E       'Waiting for child threads to terminate...'
E       'Bus EXITED'
E
E       First list contains 1 additional elements.
E       First extra element 5:
E       'Bus EXITED'
E
E         ['Bus STOPPING',
E          'Bus STOPPED',
E          'Bus EXITING',
E       +  'Bus EXITED',
E       -  'Waiting for child threads to terminate...',
E       ?                                             ^
E
E       +  'Waiting for child threads to terminate...']
E       ?                                             ^
E
E       -  'Waiting for thread Thread-23.',
E       -  'Bus EXITED']

cherrypy/test/test_bus.py:223: AssertionError

@dotlambda
Copy link
Member Author

I guess these test are just very fragile.

@dotlambda
Copy link
Member Author

@GrahamcOfBorg build python2.pkgs.cherrypy python3.pkgs.cherrypy

@dotlambda dotlambda merged commit 9fa17c5 into NixOS:master Apr 5, 2019
@dotlambda dotlambda deleted the flexget-2.20.17 branch April 5, 2019 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants