Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkl: 2019.0.117 -> 2019.3.199 #58689

Merged
merged 1 commit into from Apr 2, 2019
Merged

mkl: 2019.0.117 -> 2019.3.199 #58689

merged 1 commit into from Apr 2, 2019

Conversation

markuskowa
Copy link
Member

Motivation for this change

CC @bhipple

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa
Copy link
Member Author

markuskowa commented Apr 1, 2019 •
edited

Please note that the out hash for darwin are still outdated. I someone with a mac could please supply the output hash.

bhipple
bhipple approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as the linux side of things goes.

@markuskowa markuskowa merged commit 7464e6d into NixOS:master Apr 2, 2019
@markuskowa markuskowa deleted the upd-mkl branch April 2, 2019 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@markuskowa @veprbl @bhipple @GrahamcOfBorg