Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

salt: 2018.3 -> 2019.2, pepper: 0.5.5 -> 0.7.5 #58657

Merged
merged 2 commits into from Apr 22, 2019
Merged

salt: 2018.3 -> 2019.2, pepper: 0.5.5 -> 0.7.5 #58657

merged 2 commits into from Apr 22, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 1, 2019

Motivation for this change

Fix build of dependency pytest-rerunfailures as well :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Poked at the utilities but beyond displaying version and help
information haven't checked functionality/behavior.

@dtzWill dtzWill requested a review from FRidh as a code owner April 1, 2019 07:29
aneeshusa
aneeshusa reviewed Apr 8, 2019
View reviewed changes
Copy link
Contributor

@aneeshusa aneeshusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I tested the Salt 2019.2.0 upgrade for #58876 and it looked fine. I don't use pepper so I can't validate that change.

pkgs/tools/admin/salt/pepper/default.nix Outdated
sha256 = "1wj1k64ly6af6qsmiizlx32jxh23a37smd9wb57l5zl0x8sfqq1n";
pname = "salt-pepper";
version = "0.7.5";
src = python2Packages.fetchPypi {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine this supports Python 3 since Salt does too - can we swap this to pythonPackages?

@dtzWill
Copy link
Member Author

dtzWill commented Apr 22, 2019

Okay, thanks!

@dtzWill dtzWill merged commit 39278d9 into NixOS:master Apr 22, 2019
@dtzWill dtzWill deleted the update/salt-peper-2019-03 branch April 22, 2019 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aneeshusa aneeshusa aneeshusa left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @aneeshusa @infinisil @GrahamcOfBorg