Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sddm: 0.18.0 -> 0.18.1 #58627

Merged
merged 1 commit into from Apr 12, 2019
Merged

sddm: 0.18.0 -> 0.18.1 #58627

merged 1 commit into from Apr 12, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 31, 2019

Motivation for this change

https://github.com/sddm/sddm/releases/tag/v0.18.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

Looks safe for a backport also.

matthiasbeyer
matthiasbeyer reviewed Apr 10, 2019
View reviewed changes
pkgs/applications/display-managers/sddm/default.nix
"-DQT_IMPORTS_DIR=${placeholder "out"}/${qtbase.qtQmlPrefix}"
"-DCMAKE_INSTALL_SYSCONFDIR=${placeholder "out"}/etc"
"-DSYSTEMD_SYSTEM_UNIT_DIR=${placeholder "out"}/lib/systemd/system"
];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there a cmakeFlags attribute available? Not sure though!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub seemed to collapse the diff in a weird way. Above this is in cmakeFlags.

@worldofpeace
Copy link
Contributor

This is a point release which includes this hot fix:
Use C++ scoping for handling buffer deletion - sddm/sddm@047ef56

  • Fix crashes when creating a user session

Sounds safe and good for a backport.

@worldofpeace worldofpeace added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 12, 2019
worldofpeace
worldofpeace approved these changes Apr 12, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested sddm locally and can still do all the things.

@worldofpeace worldofpeace merged commit e3cc0e6 into NixOS:master Apr 12, 2019
@worldofpeace
Copy link
Contributor

Backported in

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer left review comments

@worldofpeace worldofpeace worldofpeace approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dtzWill @worldofpeace @matthiasbeyer @samueldr @infinisil @GrahamcOfBorg