Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cask: init at 0.8.4 #58635

Merged
merged 1 commit into from Apr 10, 2019
Merged

cask: init at 0.8.4 #58635

merged 1 commit into from Apr 10, 2019

Conversation

FlexW
Copy link

@FlexW FlexW commented Mar 31, 2019

Motivation for this change

This adds the version cask as packaged by Arch Linux AUR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bendlas
Copy link
Contributor

bendlas commented Apr 10, 2019

Hello! Thanks for submitting this!

Right now, I get error: attribute 'flexw' missing, please add your information in maintainers/maintainer-list.nix.

@bendlas bendlas mentioned this pull request Apr 10, 2019
Closed
@FlexW FlexW force-pushed the master branch 2 times, most recently from aac57a0 to 073c5d6 Compare April 10, 2019 07:21
@FlexW
Copy link
Author

FlexW commented Apr 10, 2019

Right now, I get error: attribute 'flexw' missing, please add your information in maintainers/maintainer-list.nix.

I've added the information and rebased.

@bendlas bendlas merged commit b19ccff into NixOS:master Apr 10, 2019
@bendlas
Copy link
Contributor

bendlas commented Apr 10, 2019

Already tested + used it yesterday. Thank you very much!

bendlas
bendlas reviewed Apr 10, 2019
View reviewed changes
pkgs/development/tools/cask/default.nix
doCheck = true;

dontBuild = true;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, a possible build phase would be to compile the *.el files to *.elc, which would improve startup speed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I tried it but byte compiling seems not be possible due errors caused by lexical variables.

@adisbladis
Copy link
Member

Why is this not using the sources from the generated melpa packages?
That would mean that this package would get automatic updates.

cc @FlexW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendlas bendlas bendlas left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@FlexW @bendlas @adisbladis @GrahamcOfBorg @Janik-Haag