-
-
Notifications
You must be signed in to change notification settings - Fork 362
Go back to python's sqlite module, not pysqlite2 #1119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Transactional again, this was meant to be temporary. Comment indicates python 2.7.13 has the fix, and this seems available back a few releases: 18.09: 2.7.15 18.03: 2.7.15 17.09: 2.7.14 17.03: 2.7.13 16.09: 2.7.13 -------------- 16.03: 2.7.12 This reverts commit e86e5f2.
Seems to break things for some reason, e.g one of the VPC tests:
|
since it's not urgent, I might get back to it at some point to investigate further. |
Strange-- are those part of the normal release build attribute?
(by which I mean `NIX_PATH=nixpkgs=channel:nixos-unstable nix build -f release.nix build.x86_64-linux` or so)
If so, they work here-- perhaps the problem depends on nixpkgs built
against?
…On Mon, 22 Apr 2019 11:27:18 -0700, Amine Chikhaoui ***@***.***> wrote:
since it's not urgent, I might get back to it at some point to investigate further.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#1119 (comment) part: text/html
|
@dtzWill This is not during the build, this is while running functional tests that do spin up some machines/resources and test things get deployed/destroyed etc .. |
Hello! Thank you for this PR. In the past several months, some major changes have taken place in
This is all accumulating in to what I hope will be a NixOps 2.0 My hope is that by adding types and more thorough automated testing, However, because of the major changes, it has become likely that this If you would like to see this merge, please bring it up to date with Thank you again for the work you've done here, I am sorry to be Graham |
Commit history suggests this was only meant as a temporary
workaround, and judging by history of each pysqlite2 is done
(presumably because it lives in python2 tree now)
https://pypi.org/project/pysqlite/#history
(Aug 2016)
vs.
(Actively developed)
https://github.com/python/cpython/commits/2.7/Modules/_sqlite