Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncthingtray: 0.9.1 -> 0.10.0 #68278

Merged
merged 1 commit into from
Sep 28, 2019
Merged

syncthingtray: 0.9.1 -> 0.10.0 #68278

merged 1 commit into from
Sep 28, 2019
+3 −3

Conversation

doronbehar
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Other notes

Both #68277 and #68276 need to be merged for this to work.

Sorry, something went wrong.

@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 7, 2019
@mmahut
Copy link
Member

mmahut commented Sep 9, 2019

@GrahamcOfBorg build syncthingtray-minimal syncthingtray

@doronbehar
Copy link
Contributor Author

doronbehar commented Sep 9, 2019 •
edited
Loading

As I said, both #68277 and #68276 need to be merged for the build to work.

@lheckemann lheckemann added this to the 20.03 milestone Sep 10, 2019
@doronbehar doronbehar mentioned this pull request Sep 17, 2019
Merged
10 tasks
worldofpeace
worldofpeace reviewed Sep 19, 2019
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -20645,7 +20645,7 @@ in
syncthing-tray = callPackage ../applications/misc/syncthing-tray { };

syncthingtray = libsForQt5.callPackage ../applications/misc/syncthingtray { };
syncthingtray-minumal = libsForQt5.callPackage ../applications/misc/syncthingtray {
syncthingtray-minimal = libsForQt5.callPackage ../applications/misc/syncthingtray {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when was this attribute added? If it's in 19.09 like this we need to backport a change.
And I guess setup an alias, which is unfortunate if anyone has that in their config.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was committed by me (git blame me 👈:) in #65480.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok, no worries. If you make it a separate commit and add an alias to aliases.nix I can backport it for you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are talking about backporting the rename for me personally (as it seems I may be the only Nix user of this package) then I don't mind it at all - I can just change it in my own nix-env.

As for other users who may have come to rely on that, I think this change won't be too bad. We've already performed such renames, e.g #65724 .

@worldofpeace worldofpeace merged commit 0727b93 into NixOS:master Sep 28, 2019
@worldofpeace
Copy link
Contributor

worldofpeace commented Sep 28, 2019 •
edited
Loading

Fixed the misspelled name in 548d0b7 on 19.09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

@ck3d ck3d

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@doronbehar @mmahut @worldofpeace @ck3d @lheckemann