Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update arduino to 1.8.9 #68211

Closed
wants to merge 2 commits into from
Closed

update arduino to 1.8.9 #68211

wants to merge 2 commits into from

Conversation

bergey
Copy link
Contributor

@bergey bergey commented Sep 6, 2019 •
edited

Motivation for this change

Update to latest upstream version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from bjornfor September 6, 2019 15:44
@bergey
Copy link
Contributor Author

bergey commented Sep 6, 2019

nix-review caught that my first commit broke teensyduino. Fixed in f95cd76. nix-review now passes.

@FRidh
Copy link
Member

FRidh commented Sep 6, 2019

Please fix your commit messages to conform to our guidelines.

bjornfor
bjornfor requested changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reorder commits to not break git bisect.

@bjornfor
Copy link
Contributor

bjornfor commented Sep 7, 2019

I reordered and pushed manually: 51c0c88, 98582c6. Thanks!

@bjornfor bjornfor closed this Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@bjornfor bjornfor bjornfor requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bergey @FRidh @bjornfor @jonringer