Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cockroachdb: 1.19.1 -> 1.19.4 #68156

Merged
merged 1 commit into from Sep 6, 2019
Merged

cockroachdb: 1.19.1 -> 1.19.4 #68156

merged 1 commit into from Sep 6, 2019

Conversation

vladdy
Copy link
Contributor

@vladdy vladdy commented Sep 5, 2019

Motivation for this change

Provide the latest available release via the package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

rvolosatovs
rvolosatovs suggested changes Sep 5, 2019
View reviewed changes
pkgs/servers/sql/cockroachdb/default.nix Outdated

goPackagePath = "github.com/cockroachdb/cockroach";

src = fetchurl {
url = "https://binaries.cockroachdb.com/cockroach-v${version}.src.tgz";
sha256 = "1vbz5j0y9ri8c99k8fc5rnwigay478p1mac5g402639ilkqd41fc";
sha256 = "d819167dc109b566511cb6cef9aadc8c4f07b1be6a8b3108f4bbd14808d21faf";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look right - try this one rvolosatovs@8c50f09#diff-538ae77f6d84d5f7800d94b0d433dd41R22 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks for correcting me! How did you obtain that hash?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct way:

nix-prefetch-url https://binaries.cockroachdb.com/cockroach-v19.1.4.src.tgz
[98.3 MiB DL]
path is '/nix/store/jl9a12xqv3dxb87c5pwjy422gyfap42f-cockroach-v19.1.4.src.tgz'
1bqzs844ildvyh4332vapsqhfkwcvjmgkkmn3i8ndd89q5yic6fq

Note, that there are also nix-prefetch-git, nix-prefetch-hg etc. available

However, I'm lazy and most of the time I just modify the hash to something random(but valid), let the build fail and use the hash from the build. It looks something like this(the hash is for a different package):

hash mismatch in fixed-output derivation '/nix/store/91qiinmi5302rrxa1q6qydpzynn8m7l8-tools-6b3d1c9':
  wanted: sha256:16cfzmfr9jv8wz0whl433xdm614dk63fzjxv6l1xvkagjmki49iy
  got:    sha256:0a2xjx9hqkash7fd2qv9hd93wcqdbfrmsdzjd91dwvnk48j61daf

But I would not recommend this approach, since it's extremely error-prone and you can very easily run into issues with e.g. caching

vladdy
vladdy commented Sep 5, 2019
View reviewed changes
Copy link
Contributor Author

@vladdy vladdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks for correcting me! How did you obtain that hash?

@rvolosatovs
Copy link
Member

You're welcome 🙂
Answered above (#68156 (comment))

@rvolosatovs
Copy link
Member

@GrahamcOfBorg build cockroachdb

rvolosatovs
rvolosatovs approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@rvolosatovs rvolosatovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and works fine on NixOS

@FRidh FRidh merged commit 0f52e11 into NixOS:master Sep 6, 2019
@risicle
Copy link
Contributor

risicle commented Sep 6, 2019

Builds and binary appears to work on macos 10.13 FWIW

@vladdy vladdy deleted the update-crdb branch September 17, 2019 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvolosatovs rvolosatovs rvolosatovs approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vladdy @rvolosatovs @risicle @FRidh @Janik-Haag