Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/iwd: add tmpfiles rule for ead service #68213

Merged
merged 1 commit into from
Sep 7, 2019
Merged

nixos/iwd: add tmpfiles rule for ead service #68213

merged 1 commit into from
Sep 7, 2019
+1 −0

Conversation

worldofpeace
Copy link
Contributor

This is needed for the wired service ead.service.
(in ReadWritePaths)

Motivation for this change

ping @colemickens

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@worldofpeace
nixos/iwd: add tmpfiles rule for ead service
3722f1d 
This is needed for the wired service ead.service.
(in ReadWritePaths)
@worldofpeace worldofpeace requested a review from Mic92 September 6, 2019 15:37
@worldofpeace worldofpeace mentioned this pull request Sep 6, 2019
Merged
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 6, 2019
dtzWill
dtzWill approved these changes Sep 7, 2019
View reviewed changes
Copy link
Member

@dtzWill dtzWill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but haven't tested.

@worldofpeace
Copy link
Contributor Author

Checked and Arch Linux has the same rules. I'm highly sure this is needed.

@worldofpeace worldofpeace merged commit 416f057 into NixOS:master Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill

@Mic92 Mic92

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @dtzWill