[sensor] Upstream sensor layout tests to wpt #18886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 6, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1770158
branch
2 times, most recently
from
2687206
to
ef85248
Compare
Rewrote /external/wpt/resources/chromium/generic_sensor_mocks.js to align with /http/tests/resources/sensor-helpers.js, but excluded those functions specific for device orientation. Merged tests from /sensor/resources/generic-sensor-tests.js to /external/wpt/generic-sensor/generic-sensor-tests.js Moved common utils into /external/wpt/generic-sensor/resources/generic-sensor-helpers.js Merged tests from /sensor/*.html to corresponding test folders under /external/wpt/, e.g. sensor/orientation-sensor.html -> external/wpt/orientation-sensor/OrientationSensor.https.html Updated all sensor tests under external/wpt/ to adapt to sensor mojom mocks Deleted folder web_tests/sensor/ Bug: 816462 Change-Id: I614ce82b7c90530b7a268d8f6a0f72cc96ea3d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770158 Commit-Queue: Wanming Lin <wanming.lin@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#695905}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1770158
branch
from
ef85248
to
7ad2338
Compare
|
@rakuco, any idea that this is still open while the CL has been landed in Chromium? |
Honry
added a commit
to Honry/web-platform-tests
that referenced
this pull request
Sep 17, 2019
jgraham
pushed a commit
that referenced
this pull request
Sep 18, 2019
|
Close and reopen to restart the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrote /external/wpt/resources/chromium/generic_sensor_mocks.js to align with
/http/tests/resources/sensor-helpers.js, but excluded those functions specific
for device orientation.
Merged tests from /sensor/resources/generic-sensor-tests.js to
/external/wpt/generic-sensor/generic-sensor-tests.js
Moved common utils into /external/wpt/generic-sensor/resources/generic-sensor-helpers.js
Merged tests from /sensor/*.html to corresponding test folders under /external/wpt/,
e.g. sensor/orientation-sensor.html -> external/wpt/orientation-sensor/OrientationSensor.https.html
Updated all sensor tests under external/wpt/ to adapt to sensor mojom mocks
Deleted folder web_tests/sensor/
Bug: 816462
Change-Id: I614ce82b7c90530b7a268d8f6a0f72cc96ea3d6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770158
Commit-Queue: Wanming Lin <wanming.lin@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695905}