Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gnome3: enable chrome-gnome-shelll #68182

Merged
merged 3 commits into from
Sep 7, 2019
Merged

nixos/gnome3: enable chrome-gnome-shelll #68182

merged 3 commits into from
Sep 7, 2019
+4 −1

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

We should this for good integration. (though I prefer to manage these things decoratively)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@worldofpeace worldofpeace requested a review from jtojnar September 6, 2019 03:11
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 6, 2019
@jtojnar
Copy link
Member

jtojnar commented Sep 6, 2019

Can we remove nixpkgs.config.firefox.enableGnomeExtensions from package’s meta.description?

@worldofpeace
Copy link
Contributor Author

nixpkgs.config.firefox.enableGnomeExtensions

Did that.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 6.topic: GNOME GNOME desktop environment and its underlying platform labels Sep 6, 2019
jtojnar
jtojnar approved these changes Sep 7, 2019
View reviewed changes
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work great:

Screenshot from 2019-09-07 03-53-04

Thanks.

@worldofpeace
Copy link
Contributor Author

Yay 🎆️, let's go.

@worldofpeace worldofpeace merged commit 93e5683 into NixOS:master Sep 7, 2019
@worldofpeace worldofpeace deleted the chrome-gnome-shell branch September 7, 2019 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @jtojnar